TypeStrong / atom-typescript

The only TypeScript package you will ever need

Home Page:https://atom.io/packages/atom-typescript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Intentions are not highlighted in TypeScript files

aminya opened this issue · comments

If I change the extension of a file to JavaScript and hold CTRL, the intentions are highlighted, but in TypeScript, nothing is returned by atom-typescript.

Well, we do provide intentions:highlight service, and it ostensibly should work regardless of file format. However, tsserver doesn't really have a way to request all available code fixes efficiently, only get code fixes for the current cursor position, and iterating over every possible document position would just be incredibly slow. So what we actually do is iterate over reported errors (which are more likely to have code fixes attached). No errors mean we can't display any code fixes, really.

Disclaimer: it's been a while since I really sifted through tsserver's API, perhaps in newer versions there are ways to get all available code fixes, I am just not aware of it.

But the only difference here is the file extension. Why one of them is fast and the other isn't? Is it because of type checking?

Eh... my guess is you're probably getting js highlights from another package.

This issue has been marked as stale because it did not have any activity for the last 90 days or more. Remove the stale label or comment or this will be closed in 14 days