Classes with generic mixins applied to base do not highlight correctly
bennypowers opened this issue · comments
Consider this file:
interface C {}
class B<T, U> {}
function F(s: any) { return class G<T, U> extends s {} }
export class A extends F(B)<D, E> implements C {}
export class A extends B<D, E> implements C {}
Expected: both instances of the word implements
highlight as modifier keywords
Actual: only the second instance highlights properly
debug info with package info
{
"atom": "1.54.0",
"platform": "darwin",
"release": "18.7.0",
"activeCommunityPackages": [
"dracula-syntax: 3.0.2",
"framer-ui: 2.0.0",
"api-docs: 0.0.6",
"atom-ide-debugger-node: 0.7.3",
"atom-ide-debugger-python: 0.7.3",
"atom-ide-javascript: 1.5.0",
"atom-import-cost: 1.2.0",
"atom-inline-blame: 0.0.10",
"atom-jq: 0.7.0",
"atom-typescript: 14.1.2",
"audio: 1.5.7",
"autocomplete-module-import: 0.3.0",
"autocomplete-paths: 2.12.18",
"busy-signal: 2.0.1",
"choose-pane: 0.8.0",
"color-picker: 2.3.0",
"counter: 0.3.5",
"custom-title: 1.0.1",
"docblockr: 0.13.7",
"emmet: 2.4.3",
"file-icons: 2.1.46",
"gitlab-integration: 0.4.8",
"haskell-debug: 0.3.6",
"haskell-pointfree: 0.2.0",
"highlight-column: 0.5.4",
"highlight-line: 0.12.0",
"highlight-selected: 0.17.0",
"ide-bash: 1.0.11",
"ide-cpp: 0.1.0",
"ide-haskell-hoogle: 0.1.2",
"ide-html: 0.6.2",
"ide-json: 0.2.1",
"indent-guide-improved: 1.4.13",
"intentions-colorpicker: 1.0.1",
"intentions-numbers: 1.0.4",
"javascript-drag-import: 0.1.13",
"language-haskell-scoped: 0.1.2",
"less-than-slash: 0.20.0",
"linter-coverage: 0.3.0",
"linter-docker: 0.3.2",
"linter-eslint: 8.5.5",
"linter-jsonlint: 1.4.0",
"linter-pylint: 2.1.1",
"linter-sass-lint: 1.9.0",
"linter-stylelint: 4.5.1",
"linter-write-good: 0.9.3",
"minimap-split-diff: 0.3.7",
"modular-snippets: 0.1.3",
"npm-outdated: 0.6.0",
"pane-browser: 1.6.0",
"pigments: 0.40.6",
"plantuml-viewer: 0.7.2",
"regex-railroad-diagram: 0.19.4",
"relative-numbers: 0.9.1",
"remember-folds: 0.3.0",
"split-diff: 1.6.1",
"teletype: 0.13.4",
"terminal-tab: 0.6.0",
"todo-show: 2.3.2",
"tree-ignore: 0.6.2",
"vim-mode-plus: 1.36.4",
"vim-mode-plus-keymaps-for-surround: 0.2.1",
"language-graphql: 1.0.0",
"language-plantuml: 0.2.0",
"language-markdown: 0.37.0",
"language-github-actions: 0.1.0",
"language-fish-shell: 1.1.0",
"language-haml: 0.32.1",
"language-ini: 1.23.0",
"language-haskell: 1.21.0",
"language-liquid: 0.7.0",
"language-mermaid: 0.6.0",
"language-nunjucks: 4.2.1",
"language-patch: 1.2.0",
"language-confluence-wiki: 0.2.0",
"language-vue: 0.26.0",
"react: 0.18.0",
"atom-beautify: 0.33.4",
"atom-ide-base: 2.3.2",
"atom-ide-datatip: 0.23.2",
"atom-ide-definitions: 0.4.1",
"atom-ide-hyperclick: 1.0.9",
"atom-ide-markdown-service: 2.0.0",
"atom-ide-outline: 1.17.0",
"atom-ide-signature-help: 0.15.1",
"linter: 3.3.0",
"linter-ui-default: 3.2.3",
"minimap: 4.39.7",
"minimap-find-and-replace: 5.0.8",
"minimap-git-diff: 4.3.6",
"minimap-linter: 2.2.2"
]
}
Edit: having submitted this issue I'm now noticing that GitHub's highlighter appears to have the same issue, so maybe it's upstream. However note VSCode's rendering:
@bennypowers I think you opened the issue in the wrong repository
This is a syntax highlighting issue and it should be opened here:
https://github.com/atom/language-typescript
moved to atom/language-typescript#57