Semester 1 (Early-Start) and Semester 1 (Extended) subjects are not included.

Question

Semester 1 (Early-Start) and Semester 1 (Extended) subjects are not included.

manu354 opened this issue 3 years ago · comments

Manu Masson commented 3 years ago

Just realized this working on subjectListScraper.ts, is it desired to have these subjects included?

If it is desired I will make a PR updating the scraper functionality to include these.

Edit: same for semester 2

rohyl · Answer 1 · Mon Jan 25 2021 18:39:49 GMT+0800 (China Standard Time)

Sure, the more periods covered the better, I guess! This will also entail front-end work to add it to the drop down list. Let me know if you need some guidance.

Manu Masson · Answer 2 · Mon Jan 25 2021 18:44:26 GMT+0800 (China Standard Time)

Will do :)

rohyl · Answer 3 · Mon Jan 25 2021 20:27:16 GMT+0800 (China Standard Time)

Hm actually, are you sure the premise is correct?

https://github.com/Trontor/lookahead/blob/master/subject-utils/scripts/subjectListScraper.ts#L118-L126

Seems like I've grouped them all under Semester 1/2

Manu Masson · Answer 4 · Mon Jan 25 2021 21:13:20 GMT+0800 (China Standard Time)

If you look at subjects-lists (before #11 was merged) there are 2099 subjects in subjects_2021_semester_1.json

If you look on the handbook at how many subjects there are with semester 1 including early and extended starts, there are 2421 subjects!

When you select only Semester 1 it drops down to 2078 subjects, however, that's still not the 2099 that the previous json has -- not sure where that discrepancy of 21 is coming from. But I am pretty sure that the larger discrepenacy is from not including early and extended start subjects.