TritonDataCenter / node-lockfd

thin wrapper around fcntl(F_SETLKW) and flock(3C)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

move flock change to 2.x stream, create v1.x branch for 1.x releases

trentm opened this issue · comments

#5 bumped the min platform requirement for this module to one that has flock. Triton components have a min platform requirement (20141030T081701Z) that is before that flock-supporting platform version.

Some Triton components (e.g. cn-agent in ticket https://smartos.org/bugview/AGENT-1047) want to update to node v4. That requires node-lockfd to bump its v8plus dep. However, we need this on the stream before the flock change.

Proposal:

  • move that to a 2.x stream (major version bump)
  • revive the 1.x stream without that change. That'll let us have a 1.2.0 that updates its v8plus dep so that cn-agent can use it with (a) node v4 and (b) platforms back to 20141030T081701Z

we'd then have:

  • a 2.0.0 release which is what the 1.1.0 breaking release is
  • a new 1.2.0 release which is the previous 1.0.1 release plus an update of the v8plus dep for node v4 compat
  • perhaps a 2.0.1 release which updates the v8plus dep for node v4 compat

I added a v1.0.1 tag.

https://cr.joyent.us/#/c/1082/ (mechanics for setting up 1.x branch)

I added a v1.1.0 tag.

https://cr.joyent.us/#/c/1083/ (for a v2.0.0 release)

See #7 for the changes for 1.x and 2.x releases with node v4 support.

lockfd@2.0.0 is published