Crash on Hide/Show with Instances

Question

Crash on Hide/Show with Instances

caseyvan opened this issue 4 years ago · comments

I ran into an odd crash while hiding, then showing two RuntimeMeshComponents that shared a RuntimeMesh. The specific issue was occurring in FRuntimeMeshComponentSceneProxy::CreateMeshBatch because Section.Buffers->VertexFactory was uninitialized. After some digging, it looked like the VertexFactory was being reset due to the reference count of that FRuntimeMeshSectionProxyBuffers instance dropping to zero. This was despite FRuntimeMeshProxy having a pointer to it, and no calls to clear up update that section. It looked to me like a race condition with reference counting, and adding ESPMode::ThreadSafe to FRuntimeMeshSectionProxyBuffers seems to have fixed it. I also noticed that FRuntimeMeshProxy is marked as thread-safe even though the section buffer was not.

Moddingear · Answer 1 · Thu Apr 15 2021 00:27:51 GMT+0800 (China Standard Time)

Can you make a PR for it ?

Chris Conway · Answer 2 · Mon Mar 06 2023 23:38:09 GMT+0800 (China Standard Time)

Closing as this is now a replaced version of the plugin so previous issues likely won't apply exactly. If you continue to have this issue on the new version, please feel free to reopen!

Thanks!