Tresjs / tres

Declarative ThreeJS using Vue Components

Home Page:https://tresjs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

comment on first line of templates affects rendering

BenoitBotton opened this issue · comments

Describe the bug

a select is meant to swap between sets of objects in the scene.
when the code has a comment on the first line of the template, objects are added to the scene, the old ones are not removed.

Reproduction

https://stackblitz.com/edit/tresjs-basic-hmkhgf?file=src%2Fcomponents%2FDonut.vue

Steps to reproduce

run the stackblitz.
change the select to 'donuts 1', a second set of donuts is added to the scene.

delete the comment in the template (Donut.vue) and refresh the view
this time when switching using the select, the scene objects are changed, not added

System Info

No response

Used Package Manager

npm

Code of Conduct

Reproduction

Here's a minimal reproduction.

Maybe relevant?

For an eventual fix, it might be worth looking into /src/core/nodeOps.ts. It doesn't return a value from a createComment call.