Giters

TrenchBroom / TrenchBroom

Cross-Platform Level Editor

Home Page:kristianduske.com/trenchbroom

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dragging a clip tool handle in a 2D view offsets it from the cursor

VanPonti opened this issue · comments

commented

System Information

TrenchBroom V2023.1 on Windows 11

Expected Behavior

The handles created by the clip tool should be able to be dragged properly, without suddenly shifting.

Steps to Reproduce

  1. Select the clip tool and make a cut.
  2. In a 2D view, select one of the handles on the cut and begin to drag it.
  3. The handle should now have noticeably "teleported" a distance away from its initial position equal to its former distance from the world origin.
    For example, if one tries to drag a clip tool handle at (0,4) in a 2D view, the handle will appear at (0,8), four units above where it was. The handle can still be dragged, albeit offset from the cursor.
commented

Some clarification: The described behavior only occurs with the 3rd grid point. If there are fewer grid points, TB will insert a new clip point at a different position instead.

Then I also found another issue while trying to reproduce this: #4507

commented

Some clarification: The described behavior only occurs with the 3rd grid point. If there are fewer grid points, TB will insert a new clip point at a different position instead.

Then I also found another issue while trying to reproduce this: #4507

Could you explain what you mean by "the 3rd grid point", please?

commented

I meant clip point.

commented

I meant clip point.

That's strange, then... For me, it doesn't matter which clip point is dragged; They all behave the same.

EDIT: Upon further experimentation, it seems that in some cases, trying to drag one of the clip points creates a third one if there is not one already (as you described), but in others the dragged clip point is simply offset regardless of the number of preexisting clip points. I think it may have something to do with whether or not there are other brushes in front of brush being clipped.

commented

@VanPonti I think I fixed all the problems; you can try one of the builds linked from the bottom of this page if you want to check it out: https://github.com/TrenchBroom/TrenchBroom/actions/runs/8102588384?pr=4509

commented

@VanPonti I think I fixed all the problems; you can try one of the builds linked from the bottom of this page if you want to check it out: https://github.com/TrenchBroom/TrenchBroom/actions/runs/8102588384?pr=4509

Yes it does!