Vertaisarviointi
jeesp opened this issue · comments
jeesp commented
Code review done 8.10.2021 at 10-12.
Some points:
- The code is well commented
- The variables are at some points quite shortly named, it is quite hard to get on track what is going on
- Pylint gives 1.13/10, there is at least tests involved in the pylint check, maybe they could be ignored
- The program seems to be working good, even though it takes a lot of time to process the data
- It would be nice that somewhere is explained what the graphs are showing
- All the files are in the same directory, you could do seperate folders for gui, tests etc.
Overall you seem to be knowing what you're doing, keep going on :)