Default cache TTL only 30 seconds? (Laravel 5.8 changed TTL units)
chuck-wood opened this issue · comments
In Laravel 5.8, the cache item time-to-live changed from minutes to seconds.
The default cache TTL in GeoIP is "30":
- https://github.com/Torann/laravel-geoip/blob/master/src/Cache.php#L30
- https://github.com/Torann/laravel-geoip/blob/master/config/geoip.php#L138
I presume this was supposed to be 30 minutes, not 30 seconds? The unit is not specified in the documentation, which would be useful either way.
Recommended fix: change 30 in the above locations to 1800.