MinifiedTypescript sample: minimized javascript doesn't end up in dist folder
BurtHarris opened this issue · comments
Even after fixing #107, when I build the MinifiedTypescript sample, it doesn't end up with a scripts.js file in the dist directory along with index.html.
I don't think this is working as expected, but not sure I'm reading your intent correctly.
Build spew
C:\try\tsproject\MinifiedTypescript>gulp
[01:09:10] Using gulpfile C:\try\tsproject\MinifiedTypescript\gulpfile.js
[01:09:10] Starting 'html'...
[01:09:10] Starting 'ts'...
[TsProject] Building Project with: ./src/app/tsconfig.json
[TsProject] TypeScript compiler version: 2.3.4
[TsProject] Compiling project files...
[TsProject] Files: 10
[TsProject] Lines: 30
[TsProject] Pre-emit time: 1.04s
[TsProject] Emit time: 0.00s
[TsProject] Compile time: 1.04s
[TsProject] Building bundle: src\app\app
[TsProject] Deps gen time: 0.00s
[TsProject] Deps walk time: 0.00s
[TsProject] Source gen time: 0.00s
[TsProject] Compiling bundle...
[TsProject] Minifying bundle...
[TsProject] Minify time: 0.01s
[TsProject] Total identifiers: 21
[TsProject] Identifiers shortened: 9
[TsProject] Whitespace time: 0.00s
[TsProject] Whitespace reduction: 32.39%
[TsProject] Pre-emit time: 0.89s
[TsProject] Emit time: 0.04s
[TsProject] Compile time: 0.95s
[TsProject] Total build times...
[TsProject] Pre-build time: 0.47s
[TsProject] Compiling time: 1.04s
[TsProject] Bundling time: 0.96s
[TsProject] Build time: 2.47s
[TsProject] Project build completed successfully.
[01:09:13] Starting 'css'...
[01:09:13] Finished 'css' after 49 ms
[01:09:13] Finished 'html' after 2.56 s
[01:09:13] Finished 'ts' after 2.55 s
[01:09:13] Starting 'js'...
[01:09:13] Finished 'js' after 40 ms
[01:09:13] Starting 'default'...
Placed optimized files in dist/
[01:09:13] Finished 'default' after 899 μs
@BurtHarris Over the holidays I updated TsProject to use the latest version of Typescript. I found an issue related to package minification which I did not have time to fix. I will create a new issue here to detail my findings.
If you are still interested in TsProject I will sync the repo here with my internal development repo. Otherwise I will fix the issue as time permits. Please let me know.
The minified greeter typescript sample has been re-written for TsProject v4.0.