Provigen calls notifyChange during update when nothing has changed
jasonostrander opened this issue · comments
I believe it's incorrect to notify of an update when no rows have been affected (resulting in reloaded Cursors/Loaders). Looking at the code, it appears it just needs a conditional on numberOfRowsAffected.
@jasonostrander, thank you for reporting this.
You're correct, observers are notified even if no rows are affected.
It is effectively a missing check. Would you like to make a pull request for this ? Or do you prefer that I make the change ?
Cool. I'll submit a pull. Looks like the same thing happens for delete.
On Thu, Jul 24, 2014 at 1:18 PM, Timothée Jeannin notifications@github.com
wrote:
@jasonostrander https://github.com/jasonostrander, thank you for
reporting this.
You're correct, observers are notified even if no rows are affected.
It is effectively a missing check. Would you like to make a pull request
for this ? Or do you prefer that I make the change ?—
Reply to this email directly or view it on GitHub
#31 (comment)
.
Great! I'm looking forward your pull request. :)