Break dependency on NLog
NameOfTheDragon opened this issue · comments
Its not great to have dependencies on too many third party libraries. We can't help but depend on System.Reactive, as that's the whole point, but we probably shouldn't depend on NLog.
Suggested strategy
- Introduce an
ILoggingService
interface. - Inject the logging service as a constructor parameter were needed.
- Make a degenerate implementation that does nothing, and make that the default.
- Remove dependency on NLog.
- Create a separate project/assembly/nuget package and Implement the interface as
NLogLoggingService
.
This may be a breaking change unless we can overload all the required constructors.