Giters

ThinkUpLLC / ThinkUp

ThinkUp gives you insights into your social networking activity on Twitter, Facebook, Instagram, and beyond.

Home Page:http://thinkup.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

makeinsight generator slightly out of date

adampash opened this issue · comments

commented

I've found two small issues with the makeinsight generator, detailed below:

  1. The generated test extends the wrong class:

    class TestOfSampleInsight extends ThinkUpUnitTestCase

    ...should be:

    class TestOfSampleInsight extends ThinkUpInsightUnitTestCase

  2. The generated insight is missing the user param in the generateInsight function:

    public function generateInsight(Instance $instance, $last_week_of_posts, $number_days)

    ...should be:

    public function generateInsight(Instance $instance, User $user, $last_week_of_posts, $number_days)
commented

Also: Generator should add copyright as current year (currently it's listing copyright as 2013).

commented

Hi @adampash; I've started looking at putting togther a PR for this against master, but then realised the changes you're highlighting only affect thinkup.com. master doesn't contain the changes to generateInsight and doesn't include the ThinkUpInsightUnittestCase class.

Do you know if it would be useful for me to put this together for the thinkup.com branch, or would it be better to work on updating master first?