Docs mention code that doesn't exist
boanergies opened this issue · comments
In your guide for using the WeatherStation kit, near the end it mentions the following lines of code being in the WeatherStationdemo code:
//Thingspeak Settings
const String THINGSPEAK_CHANNEL_ID = "67824";\n
const String THINGSPEAK_API_READ_KEY = "L2VIW20QVNZJBLAK";
Looking at your past commits for the WeatherStationDemo it seems like you removed these lines at one point and then never put it back. Your tutorial encourages the user to replace these two lines with our own channel id and api read key but now they don't exist at all in the code. Is this a typo? Or is it expected the user is supposed to write it in themselves and figure out how to use the thingspeak client?
Thanks for reporting this issue! @squix78 and I will discuss this.
From what I understand this appears to be about the chapter "Collecting and Displaying Local Data", more specifically the paragraph "Displaying the data on the WeatherStation".
Looking at your past commits for the WeatherStationDemo it seems like you removed these lines
More than that, with ThingPulse/esp8266-weather-station@1866c60#diff-5e6b4def031fa9bf8efb76e3e99450293de68459125f96f12a2273021bdab369 the whole ThingspeakClient integration was removed.