Question: Any plans to provide LESS files
esdev opened this issue · comments
I'm wanting to work from LESS files, but I'm only seeing the CSS files. Is there any plan to provide the LESS files for the additional styles used in the theme? Recompiling using Bootstrap's LESS files results in the navbar disappearing.
hi @esdev
we also thought about this, and might come in some next update but for now it's like this..
i'll keep this ticket open though! :)
thanks for your feedback!
konrad
@konradsroka Good to know. I added Bootstrap 3's LESS files in and it works in general (haven't added the additional theme CSS changes into LESS yet).
I only had issues with the main navbar. Any change and recompile of Bootstrap's LESS files would trigger the collapsed small device menu, but without any visible toggle. I fixed it by renaming one of the classes that's used in the HTML of header.php. The .navbar-responsive-collapse class doesn't exist in BS3 (was deprecated in BS2). I renamed the class to .navbar-collapse and that fixed most of the issues (other than a floating issue).
@esdev, great thanks for all the detailed feedback!
You are welcome to send patches or whatever you are up to :)
cheers, konrad
@esdev is there a patch available? I am more than happy to test it.
If not what can needs to be done to map out a path to a feature release?
I have added the missing less and js files now.
I add them to resources/bootstrap/css and resources/bootstrap/js
this is how WooCommerce does it, and it will make the compiling more easy for most users if the less and css is in the same folder.
Please recheck my changes and tell me your thoughts.
I have created a new 1.1 version for now. https://github.com/Themekraft/_tk/releases/tag/v1.1
Thanks for your feedback,
Sven