TheWidlarzGroup / react-native-video

A <Video /> component for react-native

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[iOS] Not getting callback when fullscreen player is dismissed via controls

acgourley opened this issue · comments

I would expect onVideoFullscreenPlayerWillDismiss or onVideoFullscreenPlayerDidDismiss to trigger, but they do not seem to be either on device or simulator.

Testing on iOS 10 with RN 41 and react-native-video 1.0.0

commented

Hey @acgourley
Looking at VideoManager.m, I had the same expectation.
After debugging things a little bit I discovered that these are the right props:

  • onFullscreenPlayerWillPresent
  • onFullscreenPlayerDidPresent
  • onFullscreenPlayerWillDismiss
  • onFullscreenPlayerDidDismiss

Hope this helps.

Can confirm this works for me.

<Video onFullscreenPlayerWillDismiss={this._onFullscreenPlayerWillDismiss.bind(this)} />

it's not working for me the callback onFullscreenPlayerWillDismiss

This is still not working. Either onFullscreenPlayerWillDismiss or onFullscreenPlayerDidDismiss.
Tested with react-native-video: 3.2.1 and react-native: 0.57.5

Not working with "react-native-video": "^4.2.0" and "react-native": "0.57.7"

Not working with "react-native": "^0.57.3" and "react-native-video": "4.3.0" either

Not working with "react-native": "^0.57.7" and "react-native-video": "4.3.1"

We're running into the same issue. Any updates on this?

Based on my tests it seems like those events are only emitted when fullscreen mode is opened through the player's functionality (ie. presentFullscreenPlayer), but not via the expand icon in the upper left corner of the video. There seem to be various issues with fullscreen behaviour, such as #1319. Given how long these issues have been unresolved, I wouldn't hold my breath for them to be fixed anytime soon.

Can you check on this PR?
#1669

This is a serious problem. Is someone able to fix this?

I'm having the same problem - none of the callbacks are working, any chance this could be fixed?

any updates on this?

any updates?

any update please ? still facing same issues . these callbacks are not trigger
onFullscreenPlayerWillDismiss
onFullscreenPlayerDidDismiss

Having the same issue.. any news on a fix?

Can someone please try out #2379 and let us know if it fixes the issue?