TheNitesWhoSay / RareCpp

Creating a simpler, more intuitive means of C++ reflection

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Nullptr in Json::Generic output

TheNitesWhoSay opened this issue · comments

In Put::GenericIterable there are two unguarded dereferences of field.second that can result in reads from nullptrs/uncaught exceptions

This bug has apparently been present since generics were introduced: 919607f#diff-362a45ce75c777b60c17474e1860c696e2bab52d0f2e8b6190377594f4a878acR1243 will need to ensure unit tests more thoroughly cover nulls in json generic I/O.

Fixed by f1bbfa6 , though more to go on object mapping before this can be merged

Fixed as of #75