TheAlgorithms / JavaScript

Algorithms and Data Structures implemented in JavaScript for beginners, following best practices.

Home Page:https://the-algorithms.com/language/javascript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] `DIRECTORY.md` workflow not running due to protected branch

Panquesito7 opened this issue · comments

Description

The DIRECTORY.md workflow isn't committing/pushing any needed changes due to the master branch being protected.
Currently, there's no way to make GitHub Actions have access to a protected branch.

Our current options are:

  • Disable branch protection (not recommended).
  • Commit as someone with access to making direct commits to the branch.
  • Wait until GitHub provides a solution to this.

Directory.md is currently changed in the prs themselves which I think is good enough.

Directory.md is currently changed in the prs themselves which I think is good enough.

Yeah. Although, I still think this should be kept open until GitHub actually fixes this.

The ideal scenario would be for the workflow to run only in the master.

The ideal scenario would be for the workflow to run only in the master.

That currently won't work as the master branch is protected.

Maintainer / Owner access is never able to force push again for default & protected branch,

Description

The DIRECTORY.md workflow isn't committing/pushing any needed changes due to the master branch being protected.
Currently, there's no way to make GitHub Actions have access to a protected branch.

Our current options are:

  • Disable branch protection (not recommended).
  • Commit as someone with access to making direct commits to the branch.
  • Wait until GitHub provides a solution to this.

@raklaptudirm, should I change the workflow to create a PR to the repository, just like in other repositories such as C/C++?

@raklaptudirm, should I change the workflow to create a PR to the repository, just like in other repositories such as C/C++?

That would be best imo.