TheAlgorithms / JavaScript

Algorithms and Data Structures implemented in JavaScript for beginners, following best practices.

https://the-algorithms.com/language/javascript

Improper and incomplete implementation of CycleDetection.js

10kartik opened this issue 2 years ago · comments

Kartik K commented 2 years ago

Implementation of CycleDetection.js seems inappropriate.

Weird function name main() and its invocation can cause the program to crash.
Tests are missing.
Not exported, Hence not resuable.
Can be optimized further (Optional)

Lars Müller commented 2 years ago

The algorithm is complete. It has poor code quality though, as you have pointed out. Feel free to fix it.