Giters

TelescopeSt / Telescope

Telescope is an engine for efficiently creating meaningful visualizations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Actions condition should follow the standard of providing entity then node as block parameter

Larcheveque opened this issue · comments

commented

The change is to do here:

generateInteractionsOf: aDrawable targetingDrawable: aTargetDrawable
	aDrawable allInteractions
		select: [ :anInteraction | anInteraction condition value: aTargetDrawable ]
		thenDo: [ :anInteraction | anInteraction generateWith: self on: aDrawable targeting: aTargetDrawable ]

should become

generateInteractionsOf: aDrawable targetingDrawable: aTargetDrawable
	aDrawable allInteractions
		select: [ :anInteraction | anInteraction condition cull: aTargetDrawable entity cull: aTargetDrawable ]
		thenDo: [ :anInteraction | anInteraction generateWith: self on: aDrawable targeting: aTargetDrawable ]
commented

non sense because action can be performed on drawables without entity