GCDWebServer version
andreialecu opened this issue · comments
I believe this is using an old version of GCDWebServer
, and that newer versions of it wouldn't require setting the Enable Bitcode
setting to NO
.
I'm not sure where this plugin sets which version to use, I couldn't find it anywhere in the source. Would it be possible to update to a newer version of GCDWebServer?
It's this 10 month old version - where have you seen the change related to bitcode exactly?
https://github.com/swisspol/GCDWebServer/search?utf8=✓&q=bitcode
This one has it enabled.
How much does this bother you / your project? I'm not entirely sure how much effort it would be for us to upgrade, so that's why I'm asking.
Doesn't bother me too much but I believe having bitcode enabled would be beneficial in the long run.
Where exactly does that pinned version come from? I looked in the repository and couldn't find it. I was expecting a git submodule but I'm not seeing it.
Alright, I found it at https://github.com/Icenium/cordova-plugin-webserver/tree/master/src/ios
According to https://github.com/Icenium/cordova-plugin-webserver/commits/master, there have been recent commits here, one specifically mentioning bitcode support. It wasn't published to npm however.
I wonder whether the maintainer there could publish it to npm - I see it is maintained by Telerik, so maybe you have some leverage there :) - , or this project could just depend on a pinned commit instead, if cordova allows that.