Telerik-Verified-Plugins / ScreenOrientation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

iOS 9.3.1 breaking changes

JoeMeeks opened this issue · comments

This plugin is not working with AppBuilder 2016.2.420.3 and plugin version 1.3.3.1 on iOS 9.3.1 window.screen.lockOrientation('portrait-primary'), window.screen.lockOrientation('landscape'), and window.screen.unlockOrientation() have no effect. The same build running on an Android 5.0.1 device works as expected.

Is this verified plugin so far behind this non-verified version that I should consider switching?

https://github.com/gbenvenuti/cordova-plugin-screen-orientation

appbuilder-cordova-4 0 0

After painstakingly upgrading to unofficial plugin version 1.4.1 (screenorientation.js collision with AppBuilder project platform-specific file handling during plugin import of screenorientation.ios.js, screenorientation.android.js,screenorientation.wp8.js – see http://docs.telerik.com/platform/appbuilder/development-tools/using-the-ides/managing-assets/platform-specific-files/add-platform-specific-file) this still does not work on iOS 9.3.1.

Hey Joe, I'm updating this fork today and also add a patch which aims to solve the iOS 9 issue you're seeing.

Wow, thanks for the responsiveness on this issue, Eddy.

I was unable to install the latest version 1.4.1 in the AppBuilder Plugin Marketplace dialog. Upon further inspection of the repo I saw that the plugin.xml had version 1.4.1 so I incremented it and created a PR.

#5

This issue persists with version 1.4.0 installed from the plugin marketplace.

appbuilder-plugins-screenorientation

Hey Joe, I wasn't completely done updating the plugin (didn't update the demo app yet so didn't check in an AppBuilder app) but I am a bit surprised 1.4.0/1.4.1 (same code) doesn't fix your problem. It did fix the issue on a local Cordova CLI project.

Let me check the AppBuilder project in a little while and I'll update this issue.

Can you try to clone our demo app, build it, and deploy to an iOS 9.3 device? Locking it to landscape and portrait works great (see screenshot below). So I'm starting to think there must be something else causing the trouble you have..

img_6729

This is working great in the demo app on iOS 9.3. Thanks for the plugin update!