TeamWisp / WispRenderer

RTX Ray Tracing Renderer, made by Y3 students at Breda University of Applied Science

Home Page:https://teamwisp.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build acceleration crashes when there's no instances left

Nielsbishere opened this issue · comments

Describe the bug
Accstruct assumes there are TLASes to build, but num_global_instances for that batch is 0 and so it shouldn't attempt to. This results into a crash.

To Reproduce
Fetch feature_rt_accstruct_culling and change scene_graph's rt culling distance to 5 instead of -1. Move around until all objects (except the mirror ball) are out of view.

Expected behaviour
Should just properly cull the objects and not cause any crashes.

Screenshots
N.A.

Desktop (please complete the following information):

  • OS: Windows 10
  • Hardware: 1060 6 GiB

Additional context
N.A.

Additional context: In master seems to work for culling meshes that are present, but doesn't when they return.

Duplicate #338