TeamShinkansen / Hakchi2-CE

Tool that allows you to add more games to your NES/SNES Classic Mini

Home Page:https://discord.gg/UUvqsAR

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adding an .ips patch file for rom using the "Add More Games" button shows misleading prompt suggesting the ips file can be patched

Bag-Head opened this issue · comments

Describe the bug
I stumbled into this entirely by accident, but if you happen to click an .ips patch file when using the "Add More Games" button, a pop up prompt appears stated the ips file you added can be patched and asks if you want to apply it. This gives the false impression that games already in your games list/games you're adding could be patched simply by adding the ips file to the games list and clicking "Yes" when the prompt appears, which you cannot do. Worth noting the pop up asks you if you want to patch the .ips file you added, which obviously cannot work and creates confusion that there possibly was a way to patch roms in the games list with this method.

To Reproduce

  1. Click "Add More Games" or Click "File", "Add Games"
  2. Click on any file in .ips format
  3. See pop up prompt stating "(insert filename).ips can be patched, do you want to apply the patch?"
  4. Clicking "Yes/Yes to all"
  5. Either shows no error message or in some cases does show an error, unsure why this is the case

Expected behavior
Simple version would be for a pop up prompt to instead inform user ips files cannot be applied by using the add games option and instead instruct them to working methods, such as adding the ips file to the "patches" folder with the rom's CRC32 at the start of the file name before adding the game, but ideally it would be a welcome feature if ips files could somehow be applied to games already in the games list either via "Add More Games" or a new "File, add ips file" option, could be further improved if this option allowed you to create a duplicate rom to patch and add a separate entry on the games list with the patch applied.

Additional context
I understand this is a very rare edge case as it's one I stumbled on by accident as well as this very well could not be addressed without negatively effecting the current patching method, but hopefully improvements could be made here as it would be very convenient if roms could be patched without having to remove and readd them to the games list after putting the desired patch in the patches folder and adding the CRC32 to the file name, it's quite a clunky method in my opinion.