Giters

TeamOctolings / Octobot

A general-purpose Discord bot for moderation written in C#

Home Page:https://teamoctolings.github.io/Octobot/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reformat Octobot's code

mctaylors opened this issue · comments

commented 
          This pull request is *filled* with unnecessary formatting changes.

Originally posted by @Octol1ttle in #223 (comment)

newlines go brrr

commented

Global reformatting PRs are not a good idea IMHO. It's better to reformat pieces of code when changing them (e.g. if I change 5 lines in a method, it's alright to fix important formatting issues in these lines and a bit around them)

I tried making a few reformatting PRs myself and realised that most changes change nothing (pun not intended) of significance and in most times they actually hurt readability. It's better to reformat code only manually and only when you feel "this code is hard to read and I know how to make it better"