TeamHG-Memex / tensorboard_logger

Log TensorBoard events without touching TensorFlow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

log_images fails with new versions of scipy

davidlibland opened this issue · comments

log_images relies on scipy.misc.toimage which was deprecated in scipy v1.0.0 and removed in v1.2.0. (cf. https://docs.scipy.org/doc/scipy-1.1.0/reference/generated/scipy.misc.toimage.html#scipy.misc.toimage)

Scipy documentation suggests using Pillow's Image.fromarray directly. The following changes to tensorboard_logger.py resolve the issue for me:

line 157 change:

            # Change the following:
            scipy.misc.toimage(img).save(s, format="png")
            # to:
            Image.fromarray(img).save(s, format="png")

line 12 change:

# Remove this import:
import scipy.misc
# Replace it with:
from PIL import Image

I would be happy to issue a PR with this fix.

@davidlibland PR would be welcome, your suggestion for a fix looks great 👍