TeamHG-Memex / autologin-middleware

Scrapy middleware for the autologin

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename HTTP_PROXY to AUTOLOGIN_HTTP_PROXY

lopuhin opened this issue · comments

It seems cleaner to use AUTOLOGIN_HTTP_PROXY and AUTOLOGIN_HTTPS_PROXY instead of passing HTTP_PROXY to autologin. HTTP_PROXY is not a standard scrapy settings variable, and it's more explicit to prefix it with AUTOLOGIN_, like other variables.

But it can less convenient in some cases, perhaps, and may require some Arachnado changes.
What do you think, @kmike ?