TeamHG-Memex / Formasaurus

Formasaurus tells you the type of an HTML form and its fields using machine learning

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecation of sklearn.externals.joblib

aronmolnar opened this issue · comments

$ formasaurus init
/usr/local/lib/python3.8/site-packages/sklearn/externals/joblib/__init__.py:15: FutureWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.
  warnings.warn(msg, category=FutureWarning)

scikit-learn 0.23 was released three days ago: https://github.com/scikit-learn/scikit-learn/releases
New installations of formasaurus are not possible any more using the default pip installation.

Either, the code is adapted (import directly from joblib), or requirements.txt is updated to:

\# 0.18 is need for GroupKFold, 0.23 sklearn.externals.joblib deprecated
scikit-learn >= 0.18, <=0.22.2.post1

Current workaround is:

pip3 install formasaurus
pip3 install -U scikit-learn==0.22.2.post1

Any way to get this merged/closed and pushed to PyPi? Thanks in advance.

Looks like the environment variable for python 3.6 test is incorrect (py34).

https://travis-ci.org/github/TeamHG-Memex/Formasaurus/jobs/693885894

Screen Shot 2020-07-23 at 5 04 17 PM

Screen Shot 2020-07-23 at 5 03 57 PM

Anyone can please address the above?

It'd be good to get v0.9.0 to PyPi and be able to integrate with current sklearn versions.

Thanks in advance!

For those who can't wait for the update in PyPi, remember you can refer a pip requirements.txt dependency as a zip file.
In this case add a line like:

https://github.com/TeamHG-Memex/Formasaurus/archive/refs/tags/0.9.0.zip#sha1=87d7c0ca96c1d9292ce359e197974325bd8a7e60

I tested, 0.9.0 works.