Giters

Tarsnap / tarsnap-gui

Cross-platform GUI for the Tarsnap backup service.

Home Page:https://www.tarsnap.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build fails with Qt 5.11.0: forward declaration of 'QHeaderView'

apjanke opened this issue · comments

commented

The build fails when I try to build it against the new Qt 5.11.0 on macOS.

$ wget https://github.com/Tarsnap/tarsnap-gui/archive/v1.0.tar.gz
--2018-05-30 21:10:47--  https://github.com/Tarsnap/tarsnap-gui/archive/v1.0.tar.gz
[...]
$ /usr/local/opt/qt/bin/qmake
$ make
/usr/local/Cellar/qt/5.11.0/bin/uic forms/backuplistwidgetitem.ui -o ui_backuplistwidgetitem.h
/usr/local/Cellar/qt/5.11.0/bin/uic forms/setupdialog.ui -o ui_setupdialog.h
/usr/local/Cellar/qt/5.11.0/bin/uic forms/joblistwidgetitem.ui -o ui_joblistwidgetitem.h
[...]
/Applications/Xcode-9.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -c -pipe -stdlib=libc++ -O2 -std=gnu++11  -arch x86_64 -isysroot /Applications/Xcode-9.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.11 -Wall -W -fPIC -DAPP_VERSION=\"1.0\" -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_SQL_LIB -DQT_CORE_LIB -I. -Isrc/widgets -I+= -Isrc -I/usr/local/Cellar/qt/5.11.0/lib/QtWidgets.framework/Headers -I/usr/local/Cellar/qt/5.11.0/lib/QtGui.framework/Headers -I/usr/local/Cellar/qt/5.11.0/lib/QtNetwork.framework/Headers -I/usr/local/Cellar/qt/5.11.0/lib/QtSql.framework/Headers -I/usr/local/Cellar/qt/5.11.0/lib/QtCore.framework/Headers -I. -I/Applications/Xcode-9.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/OpenGL.framework/Headers -I/Applications/Xcode-9.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AGL.framework/Headers -I. -I/usr/local/Cellar/qt/5.11.0/mkspecs/macx-clang -F/usr/local/Cellar/qt/5.11.0/lib -o tarsnapaccount.o src/tarsnapaccount.cpp
src/tarsnapaccount.cpp:147:30: error: member access into incomplete type 'QHeaderView'
    table->horizontalHeader()->setStretchLastSection(true);
                             ^
/usr/local/Cellar/qt/5.11.0/lib/QtWidgets.framework/Headers/qtableview.h:50:7: note: forward declaration of 'QHeaderView'
class QHeaderView;
      ^
1 error generated.
make: *** [tarsnapaccount.o] Error 1

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13.4
BuildVersion:	17E202

Encountered under Homebrew; see Homebrew/homebrew-core#28455.

commented

@apjanke Hi, I was trying it out with Qt 5.11 too and that is the only change required, everything else is good. @gperciva can merge PR#180.

commented

Regarding Qt 5.11, I see nice improvements in QList,TableView and QListWidget scrolling performance in both Archive list (1000+ archives) and Archive contents (600k+ files) on macOS. 👍