Talesoft / tale-jade

A complete and fully-functional implementation of the Jade template language for PHP

Home Page:http://jade.talesoft.codes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Blockquote tags confused for blocks cause exceptions

jaydenseric opened this issue · comments

Using:

blockquote Quote here

Causes the following error:

Tale\Jade\Compiler\Exception

Failed to compile Jade: Failed to parse Jade: Blocks outside a mixin always need a name

The following however works as expected:

#{blockquote} Quote here

The parser seems to be confusing blockquote for block, causing the error.

This is a doozy little bug that really confused me for a while.

Interesting.

I think this is directly related to the space-at-the-end bug.

The new lexer already has all that stuff fixed, but I can't merge it in right now ;(

Fixing it right now.

Good to know, thanks for the speedy response!

Dumb auto-close. Can you pull master and tell me if it's fixed for you?

Just worked out how to pull master using Composer.

blockquote.test Test

Works fine.

#{'blockquote'}.test Test

Does not. I guess this is a separate issue, a difference with Node Pug? It works in the online demo.

I think I incorrectly stated earlier that #{blockquote} Quote here works. It did prevent the original issue though.

I don't even know the #{'blockquote'}.test Test-stuff, is that some kind of new tag interpolation of Pug or something? :)

afaik neither Pug nor Tale Jade has tag interpolation, but feel free to prove me wrong haha

So, is your problem solved now?

Yes! Thanks :)

When do you think this will be merged as a stable release? Our site will be in production within the next few weeks and it would be nice to lock a version in Composer.

In a few minutes.

1.4.3 is released