TNRIS / iswp2022

Web application for the 2022 Texas State Water Plan

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update unsafe React lifecycle methods

JasonKleinert opened this issue · comments

React is deprecating 3 of their lifecycle methods in the upcoming version 17 release. These are:

  • componentWillMount
  • componentWillreceiveProps
  • componentWillUpdate

We should determine if it's worth updating this app or not. I know we hadn't really planned on updating the React version, but may have to eventually.

For now the code will continue to work with deprecation warnings and possible bugs. We need to identify where these are used and update our code with the recommended alternatives. Guidance found here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Affected source code

componentWillMount

  • src/app/public/src/components/PlacePivotTable.jsx
  • src/app/public/src/components/ProjectPivotTable.jsx

componentWillReceiveProps

  • src/app/public/src/components/charts/Treemap.jsx
  • src/app/public/src/components/DecadeSelector.jsx
  • src/app/public/src/components/maps/PrjThemeMap.jsx
  • src/app/public/src/components/maps/ThemeMap.jsx
  • src/app/public/src/components/PlacePivotTable.jsx
  • src/app/public/src/components/PrjThemeSelector.jsx
  • src/app/public/src/components/SrcThemeSelector.jsx
  • src/app/public/src/components/ThemeSelector.jsx
  • src/app/public/src/components/views/EntityView.jsx
  • src/app/public/src/components/views/PlaceView.jsx
  • src/app/public/src/components/views/ProjectView.jsx
  • src/app/public/src/components/views/SourceView.jsx
  • src/app/public/src/components/views/StatewideView.jsx
  • src/app/public/src/components/views/UsageTypeView.jsx
  • src/app/public/src/components/views/WmsTypeView.jsx
  • src/app/public/src/components/views/WmsView.jsx

componentWillUpdate

  • src/app/public/src/components/charts/BarChart.jsx
  • src/app/public/src/components/charts/LineChart.jsx
  • src/app/public/src/components/charts/PieChart.jsx