TLmaK0 / gravizo

How to include graphviz graphs in github README

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No @startuml found

jeanrajotte opened this issue · comments

Great tool, thanks.

Working with it in Github private repos is difficult. It used to work, but something has changed and URL-encoded diagram definition is broken now.

Because the repo is private, one can't use the indirect method - the source is not accessible.

For the direct method, Github markdown does not support multi-line <img> or ![]() images.

Therefore one must url-encode the multi-line diagram. However, the processor no longer accepts the input (this used to work).

Identical input shown here, first without "Extra compatibility", it works, but not the other way.

screen shot 2019-02-28 at 07 21 17
screen shot 2019-02-28 at 07 22 46

In case it's my diagram definition that's problematic, here's its source.

@startuml

object partner

object partner_option

partner_option : x.mode.new.02.00 = null or Y

object end_user

end_user : x_mode = null or Y

object subscription
object sku

sku : mode = null or Y

object sku_set

partner o-- partner_option
partner o-- end_user
end_user o-- subscription
sku o-- subscription
sku_set o-- partner 
sku_set o-- sku

@enduml

FYI, while playing around a little... Removing the @ in front of @enduml also yields the "No @startuml found" image. Possibly the "No @startuml found" error is a red herring...

Wow! Now it works. url-encoded returns an image. I end every line with semi-colon now. Was that the issue?

yes sure! When the request arrives to the server, it arrives without carriage returns, so, adding ";" is the only way to take care about this.

But, aren't carriage returns url-encoded?

Yes, if you use url encode of course, but if you use a direct link no, so the system always expect a ;