THLfi / koronavilkku-android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

View bindings are not set to null in onDestroyView

atte-m opened this issue · comments

Not nulling the bindings could lead to memory leaks as fragment lifecycle is different from fragment's views lifecycle. It is recommended by view binding docs https://developer.android.com/topic/libraries/view-binding#fragments

Thanks for pointing that out! We'll take a look at this for later releases

I can fix this if you allow me.

later means never @Kaaveh

The app has been shutdown, so closing the issue. Thanks for the suggestion!