After adding new network and switching to it metamask shows additional message which prevents further interactions

Question

After adding new network and switching to it metamask shows additional message which prevents further interactions

domalaq opened this issue a year ago · comments

So I call a method cy.allowMetamaskToAddAndSwitchNetwork(); which does its job well and network is added and switched. But Metamask shows a modal message with title "You have switched to BNB (for example). Things to keep in mind ..." and button "Got it". And this message is not dismissed. And further operation like cy.disconnectMetamaskWalletFromDapp(); can not be successfully executed.

Expected behavior
Modal message should be closed.

Screenshots

Desktop (please complete the following information):

OS: Pop_OS! 22.04
Synpress version: 3.7.0
CI platform (if applicable): local testing

Baqtiar · Answer 1 · Fri May 19 2023 02:32:52 GMT+0800 (China Standard Time)

Also if someone can suggest a workaround would be much appreciated.

Juan Torres · Answer 2 · Fri May 19 2023 11:55:07 GMT+0800 (China Standard Time)

Hey @domalaq please share the way you are calling the cy.allowMetamaskToAddAndSwitchNetwork() method so I can reproduce it and see if can share a solution.

Juan Torres · Answer 3 · Fri May 19 2023 12:14:00 GMT+0800 (China Standard Time)

Hey @domalaq please share the way you are calling the cy.allowMetamaskToAddAndSwitchNetwork() method so I can reproduce it and see if can share a solution.

I got it, was able to reproduce, looking at a possible solution.

Juan Torres · Answer 4 · Fri May 19 2023 22:01:57 GMT+0800 (China Standard Time)

@domalaq I have pushed a possible solution to the issue:

#763

synthetixio/synpress#55237a0c06895bf996db90723aa429213ad3fcfe

Baqtiar · Answer 5 · Sat May 20 2023 02:42:16 GMT+0800 (China Standard Time)

Hey thanks man. I'll check in a day or two, just letting you know.

…

On Fri, 19 May 2023 at 20:02 juantor16 ***@***.***> wrote: @domalaq <https://github.com/domalaq> I have pushed a possible solution to the issue: #763 <#763> synthetixio/synpress#55237a0c06895bf996db90723aa429213ad3fcfe — Reply to this email directly, view it on GitHub <#761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYVI5OWIBSDVXO6QYKFQ5DXG54OBANCNFSM6AAAAAAYGZW56Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Baqtiar · Answer 6 · Mon May 22 2023 14:10:31 GMT+0800 (China Standard Time)

heya @juantor16

Your fix works! I'll use it until it gets accepted.

Thank you very much!

Baqtiar · Answer 7 · Mon May 22 2023 15:58:55 GMT+0800 (China Standard Time)

Ok I found that usual allowNetworkToSwitch() is broken now. It tries to find additional popup but fails. I think there should be some condition like if there is additional popup then close otherwise proceed.

Juan Torres · Answer 8 · Mon May 22 2023 22:16:44 GMT+0800 (China Standard Time)

Ok I found that usual allowNetworkToSwitch() is broken now. It tries to find additional popup but fails. I think there should be some condition like if there is additional popup then close otherwise proceed.

yeah makes sense, will push the new version today.

Juan Torres · Answer 9 · Mon May 22 2023 22:27:13 GMT+0800 (China Standard Time)

Try this @domalaq d0c291b

Baqtiar · Answer 10 · Tue May 23 2023 14:25:05 GMT+0800 (China Standard Time)

Your new changes didn't work. I looked at your code and tried this snippet locally which worked:

    if ((await playwright
        .metamaskWindow()
        .locator(recipientPopupElements.popupCloseButton)
        .count()) > 0) {
      await playwright.waitAndClick(
        recipientPopupElements.popupCloseButton,
      )
    }

Also I think GotItButton is not needed to be declared. You don't use it anyway.
Looking forward to your working code! Thanks for contributing on this.

Daniel Izdebski · Answer 11 · Mon Aug 21 2023 22:07:54 GMT+0800 (China Standard Time)

Hey @domalaq @juantor16, the version with the fix for this is available under @synthetixio/synpress@3.7.2-beta.4!