Giters

Sylius / SyliusResourceBundle

Simpler CRUD for Symfony applications

Home Page:https://sylius.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cleanup aliases for `sylius.resource_metadata_collection.factory.attributes` service

diimpp opened this issue · comments

commented

Service sylius.resource_metadata_collection.factory.attributes has two aliases

SyliusResourceBundle/src/Bundle/Resources/config/services/metadata.xml

Lines 20 to 25 in 08b7ee1

<service id="sylius.resource_metadata_collection.factory.attributes" class="Sylius\Component\Resource\Metadata\Resource\Factory\AttributesResourceMetadataCollectionFactory">
<argument type="service" id="sylius.resource_registry" />
<argument type="service" id="sylius.routing.factory.operation_route_name_factory" />
</service>
<service id="Sylius\Component\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface" alias="sylius.resource_metadata_collection.factory.attributes" />
<service id="sylius.resource_metadata_collection.factory" alias="sylius.resource_metadata_collection.factory.attributes" />

  1. How about making Sylius\Component\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface primary id and sylius.resource_metadata_collection.factory.attributes an alias.
  2. Deprecate at least one of the aliases or both