find public domain/LLVM code to replace current third-party code

Question

find public domain/LLVM code to replace current third-party code

zhuowei opened this issue 9 years ago · comments

Hopefully I can get around to doing this before someone tries to use this for crypto...

zhuowei · Answer 1 · Fri Dec 18 2015 11:21:35 GMT+0800 (China Standard Time)

A Posix_spawn implementation from FreeBSD (modified to use fork instead of vfork (which is too sketchy)) worked fine.

Looks like the lack of random number generation is being caught in the unit test: test/1_stdlib/ReflectionHashing.swift aborts probably because of missing random.

zhuowei · Answer 2 · Wed Dec 23 2015 02:41:38 GMT+0800 (China Standard Time)

Need to replace the existing getline, posix_spawn, and SunSoft libm stuff with either public domain or LLVM code - https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151221/000547.html

Brian Gesiak · Answer 3 · Fri Feb 19 2016 23:37:40 GMT+0800 (China Standard Time)

I'd like to work on documenting a list of SwiftAndroid's dependencies, and which of those use incompatible licenses. I'd also like to consider sacrificing some dependencies/Swift features (see 1dde6bd for an example) in favor of merging this fork upstream. What do you all think?

Brian Gesiak · Answer 4 · Sat Feb 20 2016 02:25:03 GMT+0800 (China Standard Time)

~~getline from Android source~~ 4a39bc6
posix_spawn from FreeBSD libc
~~The SubSoft libm floating point routines in stdlib/public/stubs/android_support/~~ 4a39bc6
~~execinfo.h~~ 1dde6bd

Is that right?

Brian Gesiak · Answer 5 · Sat Feb 20 2016 05:04:31 GMT+0800 (China Standard Time)

~~Is it possible to just tear out the FreeBSD posix_spawn implementation, and instead simply have that functionality unavailable on Android?~~ I guess it isn't, since stdlib/private/SwiftPrivateDarwinExtras/Subprocess.swift and the test suite rely on it so heavily. Hmm...

zhuowei · Answer 6 · Sat Feb 20 2016 11:34:20 GMT+0800 (China Standard Time)

That should be it. The test suite doesn't require a whole lot of functionality from posix_spawn - just redirect file descriptors, if I recall; it might be possible to just rewrite it

Brian Gesiak · Answer 7 · Sat Feb 20 2016 12:00:01 GMT+0800 (China Standard Time)

I'm looking at https://github.com/apple/swift/blob/e094e9f10ca4a63e195295e74dc852e5dd5a3234/lib/Basic/Unix/TaskQueue.inc#L133, and I bet we could do something similar for the unit tests--using posix_spawn if available, and fork if not.

Joe Groff · Answer 8 · Thu Feb 25 2016 01:23:44 GMT+0800 (China Standard Time)

posix_spawn is more efficient on Darwin and Win32 (and fork doesn't exist at all in mobile Darwin variants), so we'd prefer that posix_spawn still be used when available.

Brian Gesiak · Answer 9 · Thu Feb 25 2016 01:36:28 GMT+0800 (China Standard Time)

@jckarter Absolutely. This will just be a fallback for platforms for which posix_spawn is unavailable. 👍

By the way, I notice swift/lib/Basic/Unix/TaskQueue.inc uses a macro HAVE_POSIX_SPAWN. I don't suppose you know of anything similar I can use in the Swift file swift/stdlib/private/SwiftPrivateDarwinExtras/Subprocess.swift? For the time being I'm using #if os(Android).

Brian Gesiak · Answer 10 · Sat Jun 18 2016 00:09:50 GMT+0800 (China Standard Time)

This has mostly been taken care of upstream, through a combination of raising the minimum API level and implementing custom workarounds for StdlibUnittest. Still some room for improvement, though: https://bugs.swift.org/browse/SR-1746