some mods dont show
Dan4oby opened this issue · comments
for example without version "Minecraft 1.12" filter i can find mod named Dead Cells
https://legacy.curseforge.com/minecraft/mc-mods/dead-cells
using this filter I can't find it, but this mod is for 1.12.2
Also, there is one problem - I can't get past page 400(page size is 25). It just appears an endless "loading..." and nothing happens
For the first issue: it shows up at the bottom of the first page for me with default filters.
For the second issue: This appears to be a limitiation of the Curseforge API, but I will add some proper error handling for this case.
For the first issue: it shows up at the bottom of the first page for me
You didnt understand me right. With default filters - yes, you can find it, but if you set version filter to "Minecraft 1.12" (which is main version of this mod) you cant find it
Interesting, the gameVersionTypeId is usually supposed to be a 628 for "Minecraft 1.12", but for some reason it's null here.
So the good news is that this is probably fixable for cases where both version and sub-version are selected. Unfortunately, I'm not sure if it's possible to fix searches where only the version is selected. Why is the Curseforge API so bad...
So the good news is that this is probably fixable for cases where both version and sub-version are selected. Unfortunately, I'm not sure if it's possible to fix searches where only the version is selected. Why is the Curseforge API so bad...
ok, this would help a lot, because I looked twice through all the mods for 1.12.2 on your site, and only realized towards the end that your search lost 55-60 pages of mods
i also have one feature suggestion.
Can you add license filter in resourcepacks? It would be very very useful to find open source resourcepacks
Not exposed by the API, sorry.
The first issue should also be fixed now.