Fixed header is tripping over Unified review
jetersen opened this issue · comments
Using Refined Github and Dark Theme, I get the following on unified.
Hi @Casz!
I'm pretty sure I fixed this issue. Please make sure you have the most recent update of this style.
If not, please let me know which browser and page you're seeing this on. Do you have to be a reviewer, author or anyone to see this problem?
Already updated
It's fixed for most but not for the first element 👎
https://github.com/fastlane/fastlane/pull/10690/files?diff=unified
Chrome Version 61.0.3163.100... oops UPDATING
Updated: Chrome Version 62.0.3202.62 (Official Build) (64-bit)
Still the same
First element bugged:
Second element not bugged:
@Mottie I tried adding some style and found something interesting 👍
padding-bottom: 50px;
That is odd... I don't think Refined GitHub is adding that inline style. And we surely aren't with a css style.
I still can't duplicate the issue... I do see the first header content shift over in Firefox after hovering over the sticky header a few times; it's not consistent and seems impossible to fix. I believe that's a Firefox bug. But I can't reproduce this issue in Chrome. Did you also update GitHub-Dark?
Yup updated and all :|
Using GitHub Dark user script :| So always updated
Aha... Installing GitHub Dark from userstyles does not cause it to bug 👍
I assume it's the GitHub Dark Settings item messing with it.
Oh you mean it's the GitHub-Dark script?
Yes 👍
Hehe, sorry for not following up... Is this still an issue. I haven't seen this glitch, so I'm guessing it isn't a problem anymore?
@Mottie yup
It's definitely caused by a mixture of GitHub Dark script and Fixed header. I tried disabling AutoComplete search and Refined GitHub.
Would you please share a link to that diff page.
Really it's any pull request using unified, and only effects the first file diff element 😐
So weird... now I know why I wasn't seeing this problem. I had GitHub Diff Files Filter installed - it doesn't add any css either!
I'll keep investigating.
Please test v1.1.17 and let me know if everything is working...
Just to note, I ended up adding a .js-diff-progressive-container:before block with a height of 50px. It has a big gap there, but it was the best method I could find to fix the issues... The other method involved making the first header 60px in height and did not look good.
@Mottie it is not pretty 😐 but it fixes the issue 👍
The best alternative is to install the GitHub Diff Files Filter userscript 😉
Should be all fixed now... no extra padding.