Window internal line counter not tracked independently of LY
tbsp opened this issue · comments
As described here: https://gbdev.io/pandocs/Tile_Maps.html?highlight=window#window
This results in significant graphical glitches in games which disable the Window mid-frame and re-enable it afterward (https://tbsp.itch.io/shock-lobster), depending on the line advancement to cease while the Window is disabled.
Correction: It was being tracked independently, it was just incorrectly incrementing even if the Window was disabled.
As you can probably tell, this project is a bit dead. But, I appreciate the fix so I'll merge it. First though, could you give me an example of a game that this fixes?
Edit: Obviously I meant to comment on the pull request #189, but oh well. Anyway I see you mentioned Shock Lobster, I'll test it. Might not get around to it until this weekend though.
Yeah, I figured it was a long shot but figured it wouldn't hurt to submit a PR anyways. I see you found my mention of Shock Lobster. It wouldn't be too had to adjust the WX value (to be off-screen) every time I disable the Window to work around the bug as well, but there may be other games that benefit from the fix.