StevenBlack / hosts

🔒 Consolidating and extending hosts files from several well-curated sources. Optionally pick extensions for porn, social media, and other categories.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove python 2 support

StevenBlack opened this issue · comments

I think we've reached this point now.

Here's a checklist in the wiki for starters.

Ready to help!!

Nissar @funilrys the branch name is python3only and I've committed the PR #730 into this new branch.

Thanks!

Does Python 2 support require a lot of effort? I still use Python 2. I think that millions of other users also continue to use Python 2.

@oqbnaslyxt Python 2 will be completely EOL in about an year and a half so it's wise to upgrade to a longer supported version.

Python 2 does it's job well. I see no reason why he should die in the near future. Python 2 will surely die. But it will take many long years. Do not bury him by force. Now even Cobol continues to be used.

In general, I just wanted to know whether will complicate to continue to support Python 2? I would be very glad of this and would be immensely grateful.

Thanks.

@oqbnaslyxt sorry man, it's been decided. Python 2 support here is toast.

Closing.

Sorry, reopening because, well, we're still working on this of course.

BTW, if we're going to use the EOL argument, I would say that we only support Python 3.5 and up. Then you should check that the version does not dip below the minimum version.

I also imagine that dropping Python 2.x would enable closure of other (Python 2.x-related) issues IINM.

Hi Steven @StevenBlack,
I think we can close this soon.

Only need someone some testers for the python3only branch to ensure that nothing is broken then we can merge it into master.

From my side there is no python2 references in the python3only branch.

Cheers,
Nissar

I just checked out python3only and re-ran my normal script without needing to make any adjustments 👍

Thanks Nissar @funilrys. I agree. I've just created Issue #769 Everyone: please test the python3only branch.

@StevenBlack @funilrys : BTW, once python3only is merged, we should go back and start closing issues related to Python 2 (I spotted a couple that are still open).

@gfyoung and Nissar @funilrys, I've executed a test rebase here and everything looks good!

Once merged, I'll bump the version to 2.0.0, change a few things in the README, and bob's y'er uncle.

The deed is done. Announcing Release 2.0.0!

Thank you everybody!

Closing.