changing the Coda tables can't make stampy completely crash
MatthewBaggins opened this issue · comments
When loading tables from Coda, Stampy assumes they're going to contain columns with particular names.
There are 2 main ways this is problematic
- Hiding a column in Coda UI also hides it from API requests, so when Stampy tries to access that column, it causes a
KeyError. This has already happened.
Solution: Make Stampy download the entire table or, even better, some subset of its columns, regardless of what is visible in the UI - Changing the name of a column causes the same kind of problem. This hasn't happen yet but might in the future.
Solution: Make Stampy use column IDs which are immutable, so changing column names will not cause any problems
For reference, here is the library we use to interact with Coda: https://github.com/Blasterai/codaio
and here is Coda API documentation: https://coda.io/developers/apis/v1#section/Using-the-API
I'm happy to do it, but can promise to have time for it no earlier than 19 VI.
column ids can be deleted too, but I guess there is lower probability of unintentional damage (assuming accidental renaming is easier than deletion in Coda) + we already use table/view ids instead of table/view names => switching from column names to ids sounds OK
the main change to avoid Coda bugs could be to start using the raw Coda table with id grid-sync-1059-File with all columns instead of the Coda UI view with id table-YvPEyAXl8a that only shows the UI-visible columns from https://coda.io/d/_dfau7sl2hmG#_tutable-YvPEyAXl8a and is being used currently for
Line 45 in 15d4af6
but the top priority should be make stampy not crash on Coda errors IMHO (or do we always want to crash on initialization Coda errors, just make those errors visible in #269? I think it shouldn't crash completely, but not a strong opinion)