Spomky-Labs / pwa-bundle

PHP library for generating a full featured PWA manifest

Home Page:https://pwa.spomky-labs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add some placeholder images/pages

tacman opened this issue · comments

Description

It'd be nice to have some placeholder images that can be overridden and customized but worked out of the box

For example.

            offline_fallback:
               
                image: 'images/offline.svg'

We'd need to find some open source or cc-no-attribution files, of course.

Similarly, we could add some default pages for offline at bundle level. I'll experiment with that in pwa-extra-bundle.

Example

No response

The problem is that if any of the offline_fallback option is set, then the offline feature is enabled. Some users may want to keep it disabled.

How about adding the assets to the repo, but commenting them out in the yaml.

In particular, an offline.svg in the bundle would safe the effort of looking one up when the default might be fine.