Spomky-Labs / pwa-bundle

PHP library for generating a full featured PWA manifest

Home Page:https://pwa.spomky-labs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pwa:create:screenshot dumps an invalid configuration

tacman opened this issue · comments

Version(s) affected

1.1.x

Description

Using the YAML generated from the screenshot command throws an error

image

How to reproduce

 bin/console pwa:create:screenshot https://127.0.0.1:8013/ --output=homepage

PWA - Take a screenshot
=======================

                                                                                                                        
 [OK] Screenshot saved. You can now use it in your application configuration file.                                      
                                                                                                                        

pwa:
  screenshots:
    -
      src: homepage/screenshot-1200x1100.png
      width: 1200
      height: 1100
      type: image/png

Now move the generated yaml to pwa.yaml and refresh the page

Possible Solution

Probably the screenshot command yaml dumper hasn't been updated to the latest screenshot config.

Additional Context

No response

This should be fixed now

The result is now as follows:

pwa:
  manifest:
    screenshots:
      -
        src: homepage/screenshot-1200x1100.png
        width: 1200
        height: 1100
        format: image/png

Closing as fixed in 1.1.0

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.