Terrific plugin. Any way to make this compatible with Eminiarts/Nova-Tabs?

Question

Terrific plugin. Any way to make this compatible with Eminiarts/Nova-Tabs?

yo-mike opened this issue 4 years ago · comments

Mike commented 4 years ago

A grid inside of a tab would be.... dare I say? EPIC

See https://github.com/eminiarts/nova-tabs

Ian Torres · Answer 1 · Tue Feb 04 2020 04:48:51 GMT+0800 (China Standard Time)

I'll try 👍

Ian Torres · Answer 2 · Tue Feb 04 2020 07:08:19 GMT+0800 (China Standard Time)

@949mac

Well, after an investigation I understood that this package acts only on a Panel. Nova-tabs has its own component that extends the behavior of the Panel. If I overwrite it, every time an update of the other package is performed it could break the functionality of Nova-tabs. To solve this I suggested a non breacking change in their repository allowing the support of this package. The progress of this issue will depend on whether they are willing to accept the change, in other cases i have rejected changes because the maintainer do not want to support 3rd parties packages.

Mike · Answer 3 · Sat Feb 08 2020 03:51:00 GMT+0800 (China Standard Time)

Thanks for looking!

Mike · Answer 4 · Sat Feb 08 2020 04:06:22 GMT+0800 (China Standard Time)

I just looked at your pull request. It looks great and is a terrific contribution. Fingers crossed.

Ian Torres · Answer 5 · Sun Mar 08 2020 05:45:37 GMT+0800 (China Standard Time)

@949mac well, the change still stuck. But I need this feature in my proyect too. Ill try to code some non-breaking solution from here.

Ian Torres · Answer 6 · Thu Mar 12 2020 17:40:48 GMT+0800 (China Standard Time)

@949mac

Until the official repository does not make a decision, I recommend using my fork available at https://packagist.org/packages/demency/nova-tabs. It's nova-gridder compatible. I created because nova-tabs can't be using local nova installation.