Rails 5 support?
aldefouw opened this issue · comments
Has anyone made the gem work with Rails 5?
I did some preliminary testing on Rails 5, and there are some issues.
I made maily_herald-webui work with a few tweaks on a fork that I created:
https://github.com/aldefouw/maily_herald-webui/commits/master
My changes were mainly to some out of date dependencies. I also had to tweak the version code a bit to send the appropriate number of objects to the methods for Rails 5.
The web interface seems to be working pretty well, but I can't quite seem to get any mail to deliver. It seems like it gets tripped up when it tries to process the Mailers (I can post the error I am receiving if that helps) .. so I am wondering if Rails 5 changed something about ActionMailer that is incompatible.
I will do more research and try to fix it myself, but I just didn't want to be duplicating efforts if someone else is already working on Rails 5 compatibility.
If I can't make it work for Rails 5, I'll probably be forced to use some other solution. Looks really cool what's made so far!
Thanks!
Actually, we're currently working on a new release that will support Rails 5 and introduce some new cool features, fixes and improvements. Will push some new commits in the next days. Keep watching our repo!
@ljachymczyk - Awesome! Great to hear!
Are the updates going to be to Maily Herald WebUI as well?
Both.
Awesome. I can't wait to use this in my Rails 5 app, it looks amazing! Please let me know if you need any beta testers :)
@ljachymczyk How's the Rails 5 support going?
Is there a branch somewhere with the work in progress? Happy to try to help get it done, can you point me in the right direction?
@ayb - From what I can see, it looks like they're working on the 'ng' branch to me.
I've been knee deep in some other stuff right now otherwise I'd help too.
@ayb @aldefouw
Hey guys, thanks for the interest in this gem. That's correct - we're working on 'ng' branch on both core and webui gem. We've also created API (https://github.com/Sology/maily_herald-api) - feel free to check it out. It's not done yet due to other projects we're involved right now. Hopefully we can work with this soon (for now it's unlikely to finish this till the end of December).
Any news on rails 5 for WEB-UI ?
How is it going with Rails 5?
How is it going with Rails 5?
Rails 5?
I have my pull request here #30
have you been using this in production? If so, how's it going?
I get this error with that PR (well, with branch rails-5 in @Uysim's repo:
Multiple migrations have the name CreateMailyHeraldTables
even though there is exactly one migration with that name.
Update: It's picking one migration up from the gem at
~/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/maily_herald-af7243c8c099/db/migrate/20150205120443_create_maily_herald_tables.rb
Therefore, something is not right ... it should not be picked up.
Could you enable issues in your repo @Uysim, so that we follow up there? It looks like this repo is (semi?) abandoned.
Hi @cpg,
This repo isn't abandoned. Rails 5 compatible release is on its way. You can already try it on 'ng' branch. From what I see @Uysim has copied most of that branch.
The issue with migrations you're experiencing comes from a fact that we've decided to keep Maily migrations inside the gem so you don't need to copy them to your application any more.
You just need to remove migration files from your application. There's a rake task that will help you do that: rake maily_herald:upgrade:migrations_fixup.
Let me know how that goes.
@ljachymczyk I cloned from 'ng' branch. But I tested it. If my pull request is not helpful it is ok just ignore it
Any status on the release of Rails 5 compatibility?
@ballotamerica Guess not :)
Rails 5 and 6 are coming up in 'ng' branch. Feel free to try it out.
@ljachymczyk - Are there any plans for the master branch to support Rails 5 and/or Rails 6. When I first found out about this gem, I left when I saw an open issue pertaining to Rails5. It wasn't until a few months later when I stumbled upon it again.