Smithay / calloop

A callback-based Event Loop

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Investigate non-deterministic timer test failure on macos

elinorbgr opened this issue · comments

The current timer implementation on macos randomly fails the CI in a non-deterministic way. It'd be nice if someone with access to a macos computer could investigate it.

Interestingly this does not happen on an m1 mac mini, not sure why the CI environment keeps having these issues.

Is it the threaded implementation for MacOS?

Currently yes

Interestingly this does not happen on an m1 mac mini, not sure why the CI environment keeps having these issues.

It's probably due to speed or number of cores, I had a similar dog of a time trying to figure out the story behind #79 until I deliberately slowed it down by running under Tarpaulin.

Do you need to re-enable CI on OS X now that #89 is merged?

I don't think is was ever disabled...?

I thought it was removed as part of 2c40aec. There's only a macos-latest entry for the coverage job. Same if I look under the actions.

Ah yeah, I reorganized the CI when changing the coverage system. You think we need more CI runs for macos?

Not if we have one, I just couldn't find it in the GH actions.

Not sure I understand your point, coverage jobs run the test suite and fail if the test suite fails, so I suppose all is good...?

Yes, exactly, it's all fine.