generic::Fd wrapper is not necessary from Rust 1.48
detly opened this issue · comments
As of Rust 1.48, RawFd implements AsRawFd. This seems to be the only purpose served by calloop::generic::Fd (and Generic::from_fd()), so it could be removed. (It's a bit confusing having it there with no knowledge of why.)
As mentioned on Matrix, this is probably not a good reason on its own to bump the MSRV from 1.41 to 1.48. But if it ever gets bumped for other reasons, this issue can remind you that it can be removed.
(I don't know if you do deprecation for your APIs. If so, maybe that or a note in the docs would be good? Happy to do PR for either.)