feature request: add lib to xmake-repo
shevernitskiy opened this issue · comments
Hey! Thanks for a great hooking lib. You did exaclty what everybody thinking about!:)
I suggest to add lib to xmake-repo. It will be very helpful for xmake users:)
https://github.com/xmake-io/xmake-repo
I will give a try at adding it to xmake repo , even though i aint expert , i assume you'd just use the cmake backend in xmake
Hey, @shevernitskiy. Thanks for your kind words! Apologize for the late response, I had a break from C++.
I did a few attempts on adding rcmp to the xmake-repo, but it seems there's no simple and direct way to write correct xmake.lua even in case of small CMake-based project that can be added as a subdirectory otherwise. Any help is highly appreciated, I'm leaving this issue as opened.
@waruqi, thank you for your help! As I see from your PR to xmake-repo, you wrote some duplicated code, i.e. specified /include directory directly and added some defines for library version. I'm wondering if it's really needed? Can I somehow modify rcmp or CMakeLists.txt so xmake "recipe" becomes simpler?
specified /include directory directly and added some defines for library version
- provide cmake install configuration to install headers/libs in CMakeLists.txt
- support static/shared for BUILD_SHARED_LIBS
- generate config.h file to save RCMP_VERSION_MAJOR/RCMP_VERSION_MINOR/RCMP_VERSION_PATCH or define them in rcmp code, otherwise when the user uses the library header files, they are undefined