Updates for new mouse/keyboard select feature
SliceOfBread opened this issue · comments
#52 really works great! I think we need to add a couple of things.
-
a link (or something) to the README to explain the new drag and keyboard features.
-
The selected layer is now closed when selecting/dragging with the mouse. I would think we would want to open it, no? Or, if not, indicate the selected layer in some other way.
@greg-1-anderson
It was originally my concept that clicking on an object should open its layer. I took a step back from this not because I think the current UX is better, but because I wanted to get to a working MVP with consistent state sooner. I think that ideally, the layer information pane would open when its corresponding item is clicked, but doing this would require live-updating the information in the pane when a keyboard or mouse action changed a value.
As it is now, if you click a layer (in the list) to select it, you can only update it manually. If you click a layer in the canvas, you can only update it via drag or keyboard. I think this is confusing. Most of selectLayer() is just updating the layer parameters. A quick look and I think it starts at the comment :
// hide/unhide correct params for this layer
This could be subroutined (I think) and called here and after a drag or keyboard update, I think.
Those sound like good pointers. I will return to contributing here or in similar issues in the future, but at the moment I don't see having time until after Halloween.