AWS S3 path format issue

Question

AWS S3 path format issue

midisfi opened this issue 4 years ago · comments

While trying to test the tool we ran into an issue with S3 bucket path failing to be recognized. The utils.py file has five tests for different ways of accessing S3 objects, but after creating a new bucket for the json object, the path was not recognized.

S3 link: https://BUCKETNAME.s3.REGION.amazonaws.com/test.json

We simply used a supported format to make this work, but it would better if the above S3 path format was recognized out of the box.

Oliver Crawford commented 4 years ago

PR: #92

Oscar Blanco · Answer 1 · Fri Jan 03 2020 22:38:35 GMT+0800 (China Standard Time)

Hi @saariomi!
Thanks for letting us know this URL format!
Yes, we need to update this function extract_bucket_name_and_path_from_url (https://github.com/Skyscanner/cfripper/blob/master/cfripper/model/utils.py#L37) to support this URL format.
Would you like to create a PR? :)

Mikko Saario · Answer 2 · Tue Jan 07 2020 00:14:49 GMT+0800 (China Standard Time)

Do I need some extra permissions to publish a branch and then create a PR?

Oliver Crawford · Answer 3 · Tue Jan 07 2020 00:43:31 GMT+0800 (China Standard Time)

@saariomi i would recommend forking this project using the "Fork" button, making changes as necessary, including tests, and then raising a PR for review (all of which would be awesome!)

Mikko Saario · Answer 4 · Tue Jan 07 2020 02:08:09 GMT+0800 (China Standard Time)

Got it, please review PR.

Oscar Blanco · Answer 5 · Wed Sep 30 2020 17:35:21 GMT+0800 (China Standard Time)

This case is now supported on the last version of CFRipper, I will close this PR 😄